support markdown link #542
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lab-paul
force-pushed
the
story/CUB-5452_support-interplation-markdown-link
branch
from
5b07149 to
37ee870
Compare
ignatiusreza
requested changes
Feb 19, 2025
There was a problem hiding this comment.
The way it is implemented in this PR has nothing to do with "parsing" markdown.
The function looks to be more of a post processor, rather than a parser. And it has specific expectation against Laboperator workflow..
If this is the direction for the implementation, then the function shouldn't live inside the markdown-parser repo..
|
closing this PR since we moved the post processing in the lo-server repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for markdown link.
Example:
[posts](https://mysite.com/{{field}})should render[posts](https://mysite.com/posts)